Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge wasm_of_ocaml #1724

Open
wants to merge 563 commits into
base: master
Choose a base branch
from
Open

Merge wasm_of_ocaml #1724

wants to merge 563 commits into from

Conversation

OlivierNicole
Copy link
Contributor

@OlivierNicole OlivierNicole commented Oct 31, 2024

This aims to merge wasm_of_ocaml, currently hosted at https://github.com/ocaml-wasm/wasm_of_ocaml, back into this repo.

This is pending on Dune support ocaml/dune#11029. For now, Dune is pinned for the CI jobs.

vouillon and others added 30 commits August 22, 2024 18:20
* added 'ellipse' method to canvasRenderingContext2D
---------

Co-authored-by: Hugo Heuzard <[email protected]>
* Support for dialogElement

* Added cancel and close events

---------

Co-authored-by: Hugo Heuzard <[email protected]>
* Compiler: fix free variable for classes
…ith OCaml libraries

Use: js_of_ocaml --toplevel --no-runtime runtime.js library.cma
@vouillon
Copy link
Member

One thing that would help A LOT would be identify all packages broken by this PR and add an upper bound on the js_of_ocaml version (< 6.0) in the opam-repo. That would make releasing the next version much much easier.

See ocaml/opam-repository#26980

@hhugo hhugo mentioned this pull request Nov 28, 2024
@hhugo
Copy link
Member

hhugo commented Dec 2, 2024

#1631 has been merged. Can you rebase/update this PR one more (final?) time

dune-project Outdated Show resolved Hide resolved
@hhugo
Copy link
Member

hhugo commented Dec 4, 2024

@vouillon, I'm testing 9b964d9 in #1757

@hhugo
Copy link
Member

hhugo commented Dec 4, 2024

@vouillon, I'm testing 9b964d9 in #1757

I think you should cherry-pick cf96d62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants